fix(v2): navbar doc item fallback: search doc in lastVersion #4985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using a navbar doc item like:
It was previously required that myDocId exist in ALL docs versions of the sites, so that we can always link to the currently active version.
This PR makes it more fail-safe, and falls-back to looking for the doc in lastVersion, so that older versions are not forced to contain a doc with
id: myDocId
(ie we can more easily introduce a navbar link to an existing versioned site)Fix #4972
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
local :'( we don't have much test infra on the theme code and no dogfooding possible